Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Specialize first/last agg for simple types in new-streaming engine #20728

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 15, 2025

Ensures we don't use the generic AnyValue path for numeric/temporal types, string types and bools.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Jan 15, 2025
@ritchie46 ritchie46 merged commit e8d10a9 into pola-rs:main Jan 15, 2025
23 checks passed
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 162 lines in your changes missing coverage. Please review.

Project coverage is 79.71%. Comparing base (e3216b4) to head (543da92).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/reduce/first_last.rs 0.00% 131 Missing ⚠️
crates/polars-expr/src/reduce/mod.rs 0.00% 15 Missing ⚠️
crates/polars-expr/src/reduce/min_max.rs 0.00% 8 Missing ⚠️
crates/polars-expr/src/reduce/mean.rs 0.00% 4 Missing ⚠️
crates/polars-expr/src/reduce/var_std.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20728      +/-   ##
==========================================
- Coverage   79.75%   79.71%   -0.04%     
==========================================
  Files        1561     1561              
  Lines      221687   221914     +227     
  Branches     2530     2530              
==========================================
+ Hits       176796   176890      +94     
- Misses      44309    44442     +133     
  Partials      582      582              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants