New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust): Remove descending from sort options.limit #20721

Closed

nameexhaustion wants to merge 1 commit into pola-rs:main from nameexhaustion:sort-options-no-limit

+9 −35

Collaborator

nameexhaustion commented Jan 15, 2025 •

edited

Loading

Parameter seems duplicate w.r.t the top-level descending option in the struct.

Superceded by #20722


          refactor(rust): Remove descending from sort options.limit

83885f9

github-actions bot added internal rust labels

nameexhaustion closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ritchie46 Awaiting requested review from ritchie46 ritchie46 will be requested when the pull request is marked ready for review ritchie46 is a code owner

orlp Awaiting requested review from orlp orlp will be requested when the pull request is marked ready for review orlp is a code owner

c-peters Awaiting requested review from c-peters c-peters will be requested when the pull request is marked ready for review c-peters is a code owner

Labels