Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(python): Fixes an Excel test following new fastexcel release #20703

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Jan 14, 2025

Closes #20698.

Handle minor change of behaviour in yesterday's fastexcel 12.1 release.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.92%. Comparing base (a0d96f2) to head (29cc4c7).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20703      +/-   ##
==========================================
+ Coverage   79.03%   79.92%   +0.89%     
==========================================
  Files        1559     1559              
  Lines      221238   221180      -58     
  Branches     2529     2530       +1     
==========================================
+ Hits       174851   176778    +1927     
+ Misses      45806    43820    -1986     
- Partials      581      582       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 38dc65f into pola-rs:main Jan 14, 2025
17 checks passed
@alexander-beedie alexander-beedie deleted the fix-excel-test branch January 14, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pl.read_excel fails with invalid parameters: schema_sample_rows cannot be 0
2 participants