-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(python): Use PyO3 to convert between Python and Rust datetimes #20660
Conversation
478c209
to
45d66f0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20660 +/- ##
==========================================
- Coverage 79.03% 79.02% -0.01%
==========================================
Files 1559 1559
Lines 221238 221235 -3
Branches 2529 2529
==========================================
- Hits 174851 174834 -17
- Misses 45806 45819 +13
- Partials 581 582 +1 ☔ View full report in Codecov by Sentry. |
delta.num_microseconds().unwrap() | ||
}; | ||
|
||
Ok(AnyValue::Datetime(timestamp, TimeUnit::Microseconds, None)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this return the timezone info instead of None in the cases where there is one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we don't. I think eventually we have to, but then we also need to infer which timezone to set on the dtype.
7d9b9e6
to
54507d2
Compare
CodSpeed Performance ReportMerging #20660 will not alter performanceComparing Summary
|
54507d2
to
0a3fa09
Compare
Thank you @bschoenmaeckers! |
fixes #16199
Waiting for pyo3 v0.23.4 to be released. PyO3/pyo3#4835