Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 44 #47

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Feature/issue 44 #47

merged 6 commits into from
Jan 30, 2024

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Jan 29, 2024

Description

  • Add in the option to include what palettes to use when generating configs for collections

Overview of work done

  • Added the ability to have a new column of palettes, fill_missing, and ppd for each variable in the csv

Overview of verification done

  • Tested locally on generating new configs with palettes, fill_missing, and ppd for each variables

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@sliu008 sliu008 requested a review from jamesfwood January 29, 2024 21:49
@jamesfwood jamesfwood merged commit 46c8b9c into develop Jan 30, 2024
3 checks passed
@jamesfwood jamesfwood deleted the feature/issue-44 branch January 4, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesfwood jamesfwood jamesfwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliu008 @jamesfwood