Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2.x] mpi.h: adding back f2c/c2f macros #7259

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

raffenet
Copy link
Contributor

@raffenet raffenet commented Jan 8, 2025

Pull Request Description

MPI 4.1 requires the f2c/c2f apis as real functions -- symbols in libmpi.so. However, they are macros in the current MPICH ABI. Adding these macros back into mpi.h allows the appliation build with MPICH to be backward ABI compatible. Meantime, the real symbols are available for applications that needs them.

backport of #7244

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

Sorry, something went wrong.

MPI 4.1 requires the f2c/c2f apis as real functions -- symbols in
libmpi.so. However, they are macros in the current MPICH ABI. Adding
these macros back into mpi.h allows the appliation build with MPICH to
be backward ABI compatible. Meantime, the real symbols are available for
applications that needs them.
@raffenet
Copy link
Contributor Author

raffenet commented Jan 8, 2025

test:mpich/ch4/most
test:mpich/ch3/most

@raffenet raffenet merged commit 59b38ec into pmodels:4.2.x Jan 23, 2025
7 of 8 checks passed
@raffenet raffenet deleted the 4.2.x-conversion-macros branch January 23, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants