init: Add thread initialization and finalization #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shintaro-iwasaki we avoid making thread library calls directly in MPICH. Instead, we should define |
shintaro-iwasaki
force-pushed
the
fixABTInit
branch
2 times, most recently
from
0f73a88 to
c7dd13b
Compare
shintaro-iwasaki
changed the title
shintaro-iwasaki
force-pushed
the
fixABTInit
branch
from
c7dd13b to
770be9c
Compare
|
Change the flag type from |
|
Sanity checking the default tests. Need to add Argobots review job next. |
|
This was successful in manual tests. There are still further changes needed in the test suite, which we can address separately. @shintaro-iwasaki one more request. I prefer if changes to MPL are isolated into their own commit. Can you split the first commit into:
|
shintaro-iwasaki
force-pushed
the
fixABTInit
branch
from
770be9c to
7637600
Compare
|
I split the first commit into two as you suggested. |
|
Looks great. Testing one more time. |
Some threading libraries (e.g., Argobots) require explicit initialization and finalization. This patch adds new functions that that initialize and finalize an underlying threading library. Signed-off-by: Ken Raffenetti <[email protected]>
MPI_Init and MPI_Finalize call thread initialization and finalization functions, which some threading libraries require. Accordingly, this patch removes Argobots-specific code in MPI_Init. Signed-off-by: Ken Raffenetti <[email protected]>
When initialization of the threading library fails, it jumps to fn_fail and runs MPIR_Thread_CS_Finalize before thread_cs_init is called. This commit adds a flag to fix this issue. Signed-off-by: Ken Raffenetti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if Argobots is enabled,
ABT_initmust be called beforeMPI_Init, which is very cumbersomeNow Argobots has an initialization counter inside and therefore can be initialized multiple times.
This PR adds
ABT_initand correspondingABT_finalizein MPI initialization and finalization.The current implementation imposes a restriction derived from Argobots; when the Argobots option is enabled, the same thread needs to initialize and finalize the MPI runtime. See pmodels/argobots#86 for details.