Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: public params artifact #55

Merged
merged 19 commits into from
Dec 2, 2024
Merged

feat: public params artifact #55

merged 19 commits into from
Dec 2, 2024

Conversation

Autoparallel
Copy link
Contributor

@Autoparallel Autoparallel commented Nov 19, 2024

WIP.

  • Works locally!
  • This won't work until we make web-prover public or get a key to be able to pull that in as a crate.
  • Test generated AuxParams in web-prover

Waiting on https://github.com/pluto/web-prover/pull/331

@Autoparallel
Copy link
Contributor Author

Added a bit more here: serialize the ProverKey and VerifierKey

But won't work until changes are made in client-side-prover.

Using Personal Access Token to clone pluto/web-prover
@mattes
Copy link
Contributor

mattes commented Nov 21, 2024

Github CI working (as seen here), but failing for other reasons here. Should just work in main.

@Autoparallel
Copy link
Contributor Author

Not sure why I had to deal with that conflict when I pushed up a change right before it. Sometimes I'm so dumb with git I swear

@Autoparallel Autoparallel marked this pull request as ready for review November 27, 2024 16:25
@Autoparallel
Copy link
Contributor Author

Want to merge in https://github.com/pluto/web-prover/pull/331 prior to merging this and then pin to the correct commit for proofs crate.

Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this looks great! How big are these setup artifacts?

@Autoparallel
Copy link
Contributor Author

You can pull them up yourself if you go to the action

Copy link
Collaborator

@lonerapier lonerapier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this going to make our life so much easier

# Create artifacts directories
$(shell mkdir -p $(addsuffix /artifacts,$(TARGET_DIRS)))

# Default target
.PHONY: all clean
all: build
all: buildmak
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a typo? can't run this in local

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes a typo oops

@@ -0,0 +1,9 @@
[package]
name = "create-pp"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit but package name needs some love =D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol what do you suggest? Go ahead and edit it if you want!

Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@0xJepsen 0xJepsen merged commit 194d5d1 into main Dec 2, 2024
3 checks passed
@Autoparallel Autoparallel mentioned this pull request Dec 4, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants