-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: public params artifact #55
Conversation
Added a bit more here: serialize the But won't work until changes are made in |
Using Personal Access Token to clone pluto/web-prover
Github CI working (as seen here), but failing for other reasons here. Should just work in main. |
Not sure why I had to deal with that conflict when I pushed up a change right before it. Sometimes I'm so dumb with git I swear |
Want to merge in https://github.com/pluto/web-prover/pull/331 prior to merging this and then pin to the correct commit for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice this looks great! How big are these setup artifacts?
You can pull them up yourself if you go to the action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this going to make our life so much easier
# Create artifacts directories | ||
$(shell mkdir -p $(addsuffix /artifacts,$(TARGET_DIRS))) | ||
|
||
# Default target | ||
.PHONY: all clean | ||
all: build | ||
all: buildmak |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a typo? can't run this in local
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes a typo oops
@@ -0,0 +1,9 @@ | |||
[package] | |||
name = "create-pp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit but package name needs some love =D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol what do you suggest? Go ahead and edit it if you want!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
WIP.
AuxParams
inweb-prover
Waiting on https://github.com/pluto/web-prover/pull/331