refactor: reduce circuit public io #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoparallel
force-pushed
the
refactor/reduce-circuit-public-io
branch
from
df6248f to
e50763f
Compare
Autoparallel
force-pushed
the
refactor/reduce-circuit-public-io
branch
from
e50763f to
28a6ef7
Compare
devloper
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
This change reduced the public params from ~2k to ~1k by removing the standalone json parse folding stage and instead parsing inline in the subsequent extraction stages, this increases the constraint count of those stages, but public params being the dominate costs makes that worthwhile.
The outcome is faster proving, without need for complex auth.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP