Skip to content

Commit

Permalink
Remove CompiledName attributes,
Browse files Browse the repository at this point in the history
fix some xml docs,
fix Chart.withSlider/s not having an append argument
  • Loading branch information
kMutagene committed Oct 23, 2024
1 parent ceb2a4b commit b6df9ea
Show file tree
Hide file tree
Showing 5 changed files with 78 additions and 151 deletions.
2 changes: 1 addition & 1 deletion src/Plotly.NET.CSharp/ChartAPI/Chart.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public static partial class Chart
/// </summary>
/// <param name="gCharts">the charts to combine</param>
/// <returns></returns>
public static GenericChart Combine(IEnumerable<GenericChart> gCharts) => Plotly.NET.Chart.Combine(gCharts);
public static GenericChart Combine(IEnumerable<GenericChart> gCharts) => Plotly.NET.Chart.combine(gCharts);

/// <summary>
/// Creates a chart that is completely invisible when rendered. The Chart object however is NOT empty! Combining this chart with other charts will have unforseen consequences (it has for example invisible axes that can override other axes if used in Chart.Combine)
Expand Down
20 changes: 10 additions & 10 deletions src/Plotly.NET.CSharp/GenericChartExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public static void SaveHtml(
string path,
Optional<bool> OpenInBrowser = default
) =>
Plotly.NET.Chart.SaveHtml(
Plotly.NET.Chart.saveHtml(
path: path,
OpenInBrowser: OpenInBrowser.ToOption()
).Invoke(gChart);
Expand All @@ -44,7 +44,7 @@ public static void SaveHtml(
/// Saves the given chart as a temporary html file and opens it in the browser.
/// </summary>
/// <param name="gChart">The chart to show in the browser</param>
public static void Show(this GenericChart gChart) => Plotly.NET.Chart.Show(gChart);
public static void Show(this GenericChart gChart) => Plotly.NET.Chart.show(gChart);

/// <summary>
/// Sets trace information on the given chart.
Expand All @@ -65,7 +65,7 @@ public static GenericChart WithTraceInfo(
Optional<string> LegendGroup = default,
Optional<Title> LegendGroupTitle = default
) =>
Plotly.NET.Chart.WithTraceInfo(
Plotly.NET.Chart.withTraceInfo(
Name: Name.ToOption(),
Visible: Visible.ToOption(),
ShowLegend: ShowLegend.ToOption(),
Expand All @@ -80,7 +80,7 @@ public static GenericChart WithSize(
Optional<int> Width = default,
Optional<int> Height = default
) =>
Plotly.NET.Chart.WithSize(Width: Width.ToOption(), Height: Height.ToOption()).Invoke(gChart);
Plotly.NET.Chart.withSize(Width: Width.ToOption(), Height: Height.ToOption()).Invoke(gChart);

/// <summary>
/// Sets the given x axis styles on the input chart's layout.
Expand Down Expand Up @@ -155,7 +155,7 @@ public static GenericChart WithXAxisStyle<MinType, MaxType, CategoryArrayType>(
where MaxType : IConvertible
where CategoryArrayType : IConvertible
=>
Plotly.NET.Chart.WithXAxisStyle<MinType, MaxType, CategoryArrayType>(
Plotly.NET.Chart.withXAxisStyle<MinType, MaxType, CategoryArrayType>(
TitleText: TitleText.ToOption(),
TitleFont: TitleFont.ToOption(),
TitleStandoff: TitleStandoff.ToOption(),
Expand Down Expand Up @@ -266,7 +266,7 @@ public static GenericChart WithYAxisStyle<MinType, MaxType, CategoryArrayType>(
where MaxType : IConvertible
where CategoryArrayType : IConvertible
=>
Plotly.NET.Chart.WithYAxisStyle<MinType, MaxType, CategoryArrayType>(
Plotly.NET.Chart.withYAxisStyle<MinType, MaxType, CategoryArrayType>(
TitleText: TitleText.ToOption(),
TitleFont: TitleFont.ToOption(),
TitleStandoff: TitleStandoff.ToOption(),
Expand Down Expand Up @@ -316,7 +316,7 @@ public static GenericChart WithMapbox(
Optional<int> Id = default
)
=>
Plotly.NET.Chart.WithMapbox(
Plotly.NET.Chart.withMapbox(
mapbox: mapbox,
Id: Id.ToOption()
).Invoke(gChart);
Expand Down Expand Up @@ -374,7 +374,7 @@ public static GenericChart WithXAxisRangeSlider(
Optional<StyleParam.SubPlotId> Id = default
)
=>
Plotly.NET.Chart.WithXAxisRangeSlider(
Plotly.NET.Chart.withXAxisRangeSlider(
rangeSlider: rangeSlider,
Id: Id.ToOption()
).Invoke(gChart);
Expand All @@ -393,7 +393,7 @@ public static GenericChart WithLegend(
Optional<int> Id
)
=>
Plotly.NET.Chart.WithLegend(
Plotly.NET.Chart.withLegend(
legend: legend,
Id: Id.ToOption()
).Invoke(gChart);
Expand Down Expand Up @@ -460,7 +460,7 @@ public static GenericChart WithLegendStyle(
Optional<int> Id = default
)
=>
Plotly.NET.Chart.WithLegendStyle(
Plotly.NET.Chart.withLegendStyle(
BGColor: BGColor.ToOption(),
BorderColor: BorderColor.ToOption(),
BorderWidth: BorderWidth.ToOption(),
Expand Down
Loading

0 comments on commit b6df9ea

Please sign in to comment.