Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python packages with no namespace or multiple namespaces #86

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

davisagli
Copy link
Member

The basic idea here is that we always generate the package contents in src/packagename (literally packagename), and then at the end we generate additional namespace package folders and move the package contents to the right place.

Fixes #24

Depends on plone/cookieplone#43

I've tested manually but still need to write a couple automated tests.

@davisagli davisagli added the 04 type: enhancement making existing stuff better label Oct 27, 2024
requirements.txt Outdated Show resolved Hide resolved
@davisagli davisagli marked this pull request as ready for review October 31, 2024 20:22
Copy link
Member Author

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericof I added a sanity check for Cookieplone > 0.8. I think this is ready.

@ericof ericof merged commit 560ee7a into main Nov 13, 2024
9 checks passed
@ericof ericof deleted the variable-namespace-length branch November 13, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04 type: enhancement making existing stuff better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backend genearator does not allow you to set the package name with no dots.
2 participants