Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMS-6439: Adding registration_status filter option for Python SDK #251

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

rajneeshkatkam-plivo
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.72%. Comparing base (045f6bc) to head (05856fe).
Report is 74 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files          77       77           
  Lines        4990     4990           
=======================================
  Hits         4128     4128           
  Misses        862      862           
Flag Coverage Δ
unittests 82.72% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@prashantjha-plivo prashantjha-plivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do check the pending build steps

@narayana-plivo narayana-plivo merged commit 4490120 into master Nov 22, 2023
7 checks passed
@narayana-plivo narayana-plivo deleted the SMS-6439 branch November 22, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants