Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import jakarta instead of javax #246

Open
wants to merge 1 commit into
base: 3.0.x
Choose a base branch
from

Conversation

rozkerim
Copy link
Contributor

As stated in the Play framework documentation, Play will no longer support javax.inject after the next major release.

@mkurz
Copy link
Member

mkurz commented Jun 21, 2024

As stated in the Play framework documentation, Play will no longer support javax.inject after the next major release.

Yes that's right, however I will not merge this PR in the 3.0.x release, because currently all DI code is still javax based (even though jakarta is already supported by Guice 6). Let's keep this PR open to merge later when we switched Play itself to jakarta (which will happen soon).

@cruiztorresj
Copy link

... because currently all DI code is still javax based. ... when we switched Play itself to jakarta (which will happen soon).

Hey, do you need some help with the above task you are depicting?

Also, today I was taking a look at the Play Framework (Once more, I mean, this is not the first time I take a look at Play Framework). And realized maybe we can change the default template to use Scala 3 instead, I am not sure how many people will agree with that of course.

def index() = Action { implicit request: Request[AnyContent] =>

Could be something like
def index = Action(Ok("Hello Play Framework"))
In the upcoming days I will be taking a look on how Givens can be used instead of the implicit request parameter so the complete example code can be reproduced. There will be the case some fellows prefer the braces syntax for the Action of course.

Please don't hesitate to provide some guidelines if you need a hand.

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants