segmented control に token v2 の hover, active を追加 #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 21296ca): https://pixiv-charcoal-web--pr656-chore-segmented-cont-fcbp6vdq.web.app (expires Wed, 01 Jan 2025 08:03:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0 |
|
Size Change: 0 B Total Size: 541 kB ℹ️ View Unchanged
|
yue4u
reviewed
Dec 5, 2024
Comment on lines
25
to
29
| .charcoal-segmented-control-radio__label:hover { | ||
| background-color: var(--charcoal-color-container-hover-a); | ||
| } | ||
| .charcoal-segmented-control-radio__label:active { | ||
| background-color: var(--charcoal-color-container-press-a); |
There was a problem hiding this comment.
aria-disabledなものに対してhover/activeないほうが自然な気がします
Comment on lines
37
to
50
| .charcoal-segmented-control-radio__label[data-checked='true']:hover { | ||
| background-color: var(--charcoal-color-container-primary-hover); | ||
| } | ||
| .charcoal-segmented-control-radio__label[data-checked='true']:active { | ||
| background-color: var(--charcoal-color-container-primary-press); | ||
| } | ||
|
|
||
| .charcoal-segmented-control-radio__label[aria-disabled]:not( | ||
| [aria-disabled='false'] | ||
| ) { | ||
| cursor: default; | ||
| opacity: 0.32; | ||
| } | ||
|
|
There was a problem hiding this comment.
data-checked='true'なものに対してhover,activeなくてもいい気がするが確認が必要かもしれないです
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
naporin0624
changed the base branch from
v4.0.0
to
revert-663-revert-604-naporitan/replace-token1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
動作確認環境
チェックリスト
不要なチェック項目は消して構いません