Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CodeQL) Sets requireSSL attribute to true on forms and httpCookies. #6

Conversation

pixeebot[bot]
Copy link

@pixeebot pixeebot bot commented Jun 20, 2024

Remediation

This change fixes findings identified by CodeQL.

Details

Flipped attribute to true.

I have additional improvements ready for this repo! If you want to see them, leave the comment:

@pixeebot next

... and I will open a new PR right away!

🧚🤖 Powered by Pixeebot

Feedback | Community | Docs | Codemod ID: codeql:dotnet/requiressl-true

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots

See analysis details on SonarCloud

</assemblies>
</compilation>
<!-- show detailed error messages -->
<customErrors mode="Off" />

<customErrors mode="Off"></customErrors>

Check failure

Code scanning / CodeQL

Missing global error handler High

'customErrors' mode set to off in Web.config, and no 'Application_Error' handler specified in the global.asax file.
Copy link
Author

pixeebot bot commented Jun 28, 2024

I'm confident in this change, but I'm not a maintainer of this project. Do you see any reason not to merge it?

If this change was not helpful, or you have suggestions for improvements, please let me know!

Copy link
Author

pixeebot bot commented Jun 29, 2024

Just a friendly ping to remind you about this change. If there are concerns about it, we'd love to hear about them!

Copy link
Author

pixeebot bot commented Jul 5, 2024

This change may not be a priority right now, so I'll close it. If there was something I could have done better, please let me know!

You can also customize me to make sure I'm working with you in the way you want.

@pixeebot pixeebot bot closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants