✨ (CodeQL) SQL query built from user-controlled sources

pixee · May 13, 2024 · 21dd513 · 21dd513
1 parent 1c6cab1
commit 21dd513
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/WebGoat/App_Code/DB/MySqlDbProvider.cs b/WebGoat/App_Code/DB/MySqlDbProvider.cs
@@ -200,8 +200,9 @@ public string GetCustomerEmail(string customerNumber)
 
                 using (MySqlConnection connection = new MySqlConnection(_connectionString))
                 {
-                    string sql = "select email from CustomerLogin where customerNumber = " + customerNumber;
+                    string sql = "select email from CustomerLogin where customerNumber = @customerNumber";
                     MySqlCommand command = new MySqlCommand(sql, connection);
+                    command.Parameters.AddWithValue("@customerNumber", customerNumber);
                     output = command.ExecuteScalar().ToString();
                 } 
             }