Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cartesia.py to use the new model pointer sonic #1079

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ecdeng
Copy link
Contributor

@ecdeng ecdeng commented Jan 23, 2025

…onic-english`

We are now using sonic as a pointer to the latest stable release (https://docs.cartesia.ai/build-with-sonic/models#continuous-updates). sonic-english will forever point to sonic-2024-10-19, which is already out of date.

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

Updating the model name to the updated naming conventions we rolled out.

…onic-english`

We are now using `sonic` as a pointer to the latest stable release (https://docs.cartesia.ai/build-with-sonic/models#continuous-updates). sonic-english will forever point to `sonic-2024-10-19`, which is already out of date.
@@ -88,7 +88,7 @@ def __init__(
voice_id: str,
cartesia_version: str = "2024-06-10",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is cartesia_version still needed in this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's the API version we should keep that.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

Copy link
Contributor

@markbackman markbackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for letting us know.

@markbackman markbackman merged commit e61c996 into pipecat-ai:main Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants