Add environment variable loading in moondream-chatbot demo. #1062
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, but it looks like you don't have a linter or precommits set up. Please set up either then push an update: |
markbackman
reviewed
Jan 23, 2025
| @@ -30,6 +30,7 @@ | |||
| from pipecat.processors.aggregators.openai_llm_context import OpenAILLMContext | |||
| from pipecat.processors.frame_processor import FrameDirection, FrameProcessor | |||
| from pipecat.processors.transcript_processor import TranscriptProcessor | |||
| from pipecat.services.azure import AzureSTTService, AzureTTSService | |||
There was a problem hiding this comment.
The changes in this file look like they snuck in. Can you keep the scope to the translation demo?
markbackman
reviewed
Jan 23, 2025
| @@ -24,7 +26,7 @@ | |||
| daily_helpers = {} | |||
|
|
|||
|
|
|||
| def cleanup(): | |||
| def cleanup(): # noqa: D103 | |||
There was a problem hiding this comment.
Docstrings aren't required by the linter. Can you remove the # noqa: D103 comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.