Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: simplify interface to TWCC 2/4 #3002

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jech
Copy link
Member

@jech jech commented Jan 13, 2025

This is part 2/4 of a cross-repository series.

Part 1 is pion/interceptor#297

Please don't merge until the series is complete.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.68%. Comparing base (f2191fb) to head (ab2e05f).

❗ There is a different number of reports uploaded between BASE (f2191fb) and HEAD (ab2e05f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (f2191fb) HEAD (ab2e05f)
go 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3002       +/-   ##
===========================================
- Coverage   77.77%   63.68%   -14.10%     
===========================================
  Files          89       67       -22     
  Lines       10578     3957     -6621     
===========================================
- Hits         8227     2520     -5707     
+ Misses       1857     1308      -549     
+ Partials      494      129      -365     
Flag Coverage Δ
go ?
wasm 63.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jech jech force-pushed the single-interceptor branch from 45c9e09 to 9feebd5 Compare January 13, 2025 14:49
@jech jech changed the title WIP: simplify interface to TWCC 2/4 Simplify interface to TWCC 2/4 Jan 13, 2025
@jech jech changed the title Simplify interface to TWCC 2/4 WIP: simplify interface to TWCC 2/4 Jan 13, 2025
Make it possible to add interceptors at NewPeerConnection time.
@jech jech force-pushed the single-interceptor branch from 9feebd5 to ab2e05f Compare January 13, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant