Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sdpMid and sdpMLineIndex for ICECandidates returned by OneICECandidate #2990

Merged
merged 1 commit into from
Jan 9, 2025

Add sdpMid and sdpMLineIndex to ICECandidates

58d8c7b
Select commit
Loading
Failed to load commit list.
Merged

Include sdpMid and sdpMLineIndex for ICECandidates returned by OneICECandidate #2990

Add sdpMid and sdpMLineIndex to ICECandidates
58d8c7b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 0s

77.96% (+0.20%) compared to c50ca41

View this Pull Request on Codecov

77.96% (+0.20%) compared to c50ca41

Details

Codecov Report

Attention: Patch coverage is 94.84536% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.96%. Comparing base (c50ca41) to head (58d8c7b).

Files with missing lines Patch % Lines
sdp.go 93.47% 2 Missing and 1 partial ⚠️
peerconnection.go 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2990      +/-   ##
==========================================
+ Coverage   77.76%   77.96%   +0.20%     
==========================================
  Files          89       89              
  Lines       10550    10578      +28     
==========================================
+ Hits         8204     8247      +43     
+ Misses       1853     1841      -12     
+ Partials      493      490       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.