Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make onNegotiationNeeded conform to spec #2792

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

edaniels
Copy link
Member

- Removes non-canon logic
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.01%. Comparing base (d56bead) to head (be17ffd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
+ Coverage   78.91%   79.01%   +0.10%     
==========================================
  Files          87       87              
  Lines        8208     8203       -5     
==========================================
+ Hits         6477     6482       +5     
+ Misses       1263     1255       -8     
+ Partials      468      466       -2     
Flag Coverage Δ
go 80.64% <100.00%> (+0.12%) ⬆️
wasm 64.47% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels
Copy link
Member Author

@Sean-Der merging in since tests are passing and this fixes a probably nasty bug. We can revert if needed.

@edaniels edaniels merged commit 1bb9fa9 into pion:master Jun 24, 2024
17 checks passed
@edaniels edaniels deleted the negfix2 branch June 24, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant