Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SampleBuilder: Return header of sample's head packet #2681

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Feb 27, 2024

To get RTP extension data associated with the sample.

@at-wat at-wat self-assigned this Feb 27, 2024
To get RTP extension data associated with the sample.
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.50%. Comparing base (dbf2254) to head (053661f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2681      +/-   ##
==========================================
+ Coverage   76.47%   76.50%   +0.02%     
==========================================
  Files          87       87              
  Lines        9922     9926       +4     
==========================================
+ Hits         7588     7594       +6     
+ Misses       1862     1861       -1     
+ Partials      472      471       -1     
Flag Coverage Δ
go 78.04% <100.00%> (+0.03%) ⬆️
wasm 64.58% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@at-wat at-wat force-pushed the samplebuilder/return-associated-rtp-header branch from d060c35 to 053661f Compare February 27, 2024 09:04
@at-wat at-wat merged commit fa1f5d9 into master Feb 28, 2024
17 checks passed
@at-wat at-wat deleted the samplebuilder/return-associated-rtp-header branch February 28, 2024 05:52
@at-wat
Copy link
Member Author

at-wat commented Feb 29, 2024

Noticed that extensions can be added to tail packets.
It would be better to return array of the headers and make it optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants