Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark NULL and AES256CM SRTP ciphers as supported #652

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

sirzooro
Copy link
Contributor

DTLS server checks this list during handshake. Without this change new NULL and AES256CM SRTP ciphers were ignored.

DTLS server checks this list during handshake. Without this change new
NULL and AES256CM SRTP ciphers were ignored.
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.11%. Comparing base (bc3159a) to head (b843623).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   80.19%   80.11%   -0.08%     
==========================================
  Files         101      101              
  Lines        5336     5340       +4     
==========================================
- Hits         4279     4278       -1     
- Misses        687      691       +4     
- Partials      370      371       +1     
Flag Coverage Δ
go 80.14% <100.00%> (-0.08%) ⬇️
wasm 63.84% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der merged commit 6178064 into pion:master Jul 20, 2024
15 checks passed
@sirzooro sirzooro deleted the add_null_and_aes256cm_ciphers2 branch July 20, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants