Skip to content

Commit

Permalink
Mention v8js.icudtl_dat_path in README files
Browse files Browse the repository at this point in the history
  • Loading branch information
stesie committed Apr 23, 2017
1 parent 4d2118f commit 6b7ab04
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 1 deletion.
9 changes: 8 additions & 1 deletion README.Linux.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ ninja -C out.gn/x64.release/
# Install to /opt/v8/
sudo mkdir -p /opt/v8/{lib,include}
sudo cp out.gn/x64.release/lib*.so out.gn/x64.release/*_blob.bin /opt/v8/lib/
sudo cp out.gn/x64.release/lib*.so out.gn/x64.release/*_blob.bin \
out.gn/x64.release/icudtl.dat /opt/v8/lib/
sudo cp -R include/* /opt/v8/include/
```

Expand Down Expand Up @@ -137,3 +138,9 @@ sudo make install
```

Then add `extension=v8js.so` to your php.ini file. If you have a separate configuration for CLI, add it there also.

V8Js' build system assumes that the `icudtl.dat` file is located next to the `libv8.so`
library file and compiles the path into the library itself. If for whatever reason the
`icudtl.dat` file is stored at a different place during runtime, you need to set the
php.ini variable `v8js.icudtl_dat_path` to point to the file. Otherwise locale-aware
features of V8 will not work as expected.
6 changes: 6 additions & 0 deletions README.MacOS.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,9 @@ make
make test
make install
```

V8Js' build system assumes that the `icudtl.dat` file is located next to the `libv8.dylib`
library file and compiles the path into the library itself. If for whatever reason the
`icudtl.dat` file is stored at a different place during runtime, you need to set the
php.ini variable `v8js.icudtl_dat_path` to point to the file. Otherwise locale-aware
features of V8 will not work as expected.
5 changes: 5 additions & 0 deletions README.Win32.md
Original file line number Diff line number Diff line change
Expand Up @@ -168,3 +168,8 @@ Release_TS\php.exe -d extension=php_v8js.dll -d extension_dir=Release_TS\
```

Alternatively copy all stuff to c:\php\ (including the DLL files from v8 build).

V8 library itself needs to load the `icudtl.dat` file at runtime. Make sure php.ini
variable `v8js.icudtl_dat_path` points to this file; or as an alternative set
`PHP_V8_EXEC_PATH` in config.w32 to point to the directory where the dll and data file
are located.

0 comments on commit 6b7ab04

Please sign in to comment.