changes close element to button with proper accessibility rules (like…

…astore#533)
philips-emr · Feb 6, 2017 · 5213b34 · 5213b34
1 parent acd67cc
commit 5213b34
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/css/ngDialog.css b/css/ngDialog.css
@@ -102,6 +102,12 @@
   animation: ngdialog-fadeout 0.5s;
 }
 
+.ngdialog-close {
+  -webkit-appearance: none;
+  background: none;
+  border: none;
+}
+
 .ngdialog-close:before {
   font-family: 'Helvetica', Arial, sans-serif;
   content: '\00D7';
@@ -111,4 +117,4 @@
 html.ngdialog-open,
 body.ngdialog-open {
   overflow: hidden;
-}
+}
diff --git a/js/ngDialog.js b/js/ngDialog.js
@@ -519,7 +519,7 @@
                                 locals = setup.locals;
 
                             if (options.showClose) {
-                                template += '<div class="ngdialog-close"></div>';
+                                template += '<button aria-label="Dismiss" class="ngdialog-close"></button>';
                             }
 
                             var hasOverlayClass = options.overlay ? '' : ' ngdialog-no-overlay';