-
Notifications
You must be signed in to change notification settings - Fork 42
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: WebSocketConnection: Timeout on Read shuts down writing connection
webSocketConnection Read and Write had separate timeouts which, when expired, mutually closed the websocket. In case only one party of the connection was sending, the websocket was closed after the timeout despite the fact that the connection was alive. This comes from misunderstanding the impact of the Read/Write context parameter. See coder/websocket#242
- Loading branch information
1 parent
0b9f47b
commit 85843c5
Showing
1 changed file
with
64 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters