Merge pull request #165 from philippseith/bugfix/#164_negotiationCtx_…

…cancels_connection fix: negotiation context cancels connection
philippseith · Apr 8, 2023 · 41147bb · 41147bb
2 parents e507d7a + 55ff6d4
commit 41147bb
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/httpconnection.go b/httpconnection.go
@@ -130,7 +130,8 @@ func NewHTTPConnection(ctx context.Context, address string, options ...func(*htt
 			return nil, err
 		}
 
-		conn = newWebSocketConnection(ctx, nr.ConnectionID, ws)
+		// TODO think about if the API should give the possibility to cancel this connection
+		conn = newWebSocketConnection(context.Background(), nr.ConnectionID, ws)
 
 	case nr.getTransferFormats("ServerSentEvents") != nil:
 		req, err := http.NewRequest("GET", reqURL.String(), nil)