Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ard functions for tables 11 & 12 #243

Merged
merged 19 commits into from
Dec 2, 2024
Merged

Add ard functions for tables 11 & 12 #243

merged 19 commits into from
Dec 2, 2024

Conversation

edelarua
Copy link
Collaborator

Pull Request

Closes #242

Copy link
Contributor

github-actions bot commented Oct 10, 2024

badge

Code Coverage Summary

Filename            Stmts    Miss  Cover    Missing
----------------  -------  ------  -------  ------------
R/fda-fig_01.R         75       0  100.00%
R/fda-fig_02.R         75       0  100.00%
R/fda-fig_03.R        107       0  100.00%
R/fda-fig_14.R        115       0  100.00%
R/fda-table_02.R      166       0  100.00%
R/fda-table_03.R       35       0  100.00%
R/fda-table_04.R       63       0  100.00%
R/fda-table_05.R      157       3  98.09%   61, 124, 265
R/fda-table_06.R       76       0  100.00%
R/fda-table_07.R       35       0  100.00%
R/fda-table_08.R       46       0  100.00%
R/fda-table_09.R      329       0  100.00%
R/fda-table_10.R       26       0  100.00%
R/fda-table_11.R       92       0  100.00%
R/fda-table_12.R       84       0  100.00%
R/fda-table_13.R       20       0  100.00%
R/fda-table_14.R       27       0  100.00%
R/fda-table_15.R       32       0  100.00%
R/fda-table_16.R       32       0  100.00%
R/fda-table_17.R       32       0  100.00%
R/fda-table_18.R       32       0  100.00%
R/fda-table_20.R       71       0  100.00%
R/fda-table_21.R       78       0  100.00%
R/fda-table_22.R       77       0  100.00%
R/fda-table_32.R       94       0  100.00%
R/fda-table_33.R       95       0  100.00%
R/fda-table_34.R       41       0  100.00%
R/fda-table_35.R       23       0  100.00%
R/fda-table_36.R       30       0  100.00%
R/fda-table_38.R       39       0  100.00%
R/utils.R              28       0  100.00%
TOTAL                2232       3  99.87%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/fda-table_11.R      +50       0  +100.00%
R/fda-table_12.R      +44       0  +100.00%
TOTAL                 +94       0  +0.01%

Results for commit: 138d1f2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Unit Tests Summary

  1 files   30 suites   1m 21s ⏱️
137 tests 137 ✅   0 💤 0 ❌
497 runs  367 ✅ 130 💤 0 ❌

Results for commit 138d1f2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
fda-table_11 💔 $1.82$ $+2.39$ $+7$ $+1$ $0$ $0$
fda-table_12 💔 $2.27$ $+2.97$ $+11$ $+2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
fda-table_11 💀 $0.50$ $-0.50$ Table_11_generation_works_with_custom_values
fda-table_11 👶 $+1.37$ Table_11_generation_works_with_gtsummary_with_custom_values
fda-table_11 💀 $0.72$ $-0.72$ Table_11_generation_works_with_risk_difference_column
fda-table_11 👶 $+0.50$ Table_11_generation_works_with_rtables_with_custom_values
fda-table_11 👶 $+0.73$ Table_11_generation_works_with_rtables_with_risk_difference_column
fda-table_12 💔 $0.74$ $+1.45$ Table_12_generation_works_with_default_values
fda-table_12 👶 $+1.56$ Table_12_generation_works_with_gtsummary_with_custom_values

Results for commit bc95a3a

♻️ This comment has been updated with latest results.

@edelarua
Copy link
Collaborator Author

@ayogasekaram what are your thoughts on this layout for the quarto template pages?

@ayogasekaram
Copy link
Collaborator

@edelarua I like that it's been simplified! Less info to parse through too. Do we still need the rtables option? Since it can't accommodate ARDs - it might be a bit out of place now

@edelarua
Copy link
Collaborator Author

@edelarua I like that it's been simplified! Less info to parse through too. Do we still need the rtables option? Since it can't accommodate ARDs - it might be a bit out of place now

I think we should keep the rtables stuff for now until we decide to remove it from the package altogether. Since most functions are still only creating rtables we can keep them for reference and once everything is converted maybe remove it all at once. What do you think?

Keep in mind we'll also need to make updates in a bunch of other places at some point with an explanation of the new direction of the package.

@edelarua edelarua added the ARD label Nov 13, 2024
Copy link
Collaborator

@ayogasekaram ayogasekaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thanks @edelarua

@edelarua edelarua merged commit 3b9ab1c into main Dec 2, 2024
24 checks passed
@edelarua edelarua deleted the 242_ard_tbl_11_12@main branch December 2, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New ARD]: Table 11 & 12
2 participants