-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ard functions for tables 11 & 12 #243
Conversation
Code Coverage Summary
Diff against main
Results for commit: 138d1f2 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 30 suites 1m 21s ⏱️ Results for commit 138d1f2. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit bc95a3a ♻️ This comment has been updated with latest results. |
@ayogasekaram what are your thoughts on this layout for the quarto template pages? |
@edelarua I like that it's been simplified! Less info to parse through too. Do we still need the rtables option? Since it can't accommodate ARDs - it might be a bit out of place now |
I think we should keep the rtables stuff for now until we decide to remove it from the package altogether. Since most functions are still only creating rtables we can keep them for reference and once everything is converted maybe remove it all at once. What do you think? Keep in mind we'll also need to make updates in a bunch of other places at some point with an explanation of the new direction of the package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! thanks @edelarua
Pull Request
Closes #242