Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify key profile #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ability to specify key profile #44

wants to merge 2 commits into from

Conversation

cdodd
Copy link
Contributor

@cdodd cdodd commented Jan 29, 2016

This pull request adds the ability to specify which key pair profile to use when working with a stack. For reference see http://docs.aws.amazon.com/cli/latest/userguide/cli-chap-getting-started.html#cli-multiple-profiles. This allows you to work on stacks in different accounts without needing to manually switch out credential information.

This is optional, if key_profile is not specified in the stack then you will see the current behaviour, which is to use the default profile.

@cdodd
Copy link
Contributor Author

cdodd commented Jan 29, 2016

I see the CircleCI checks are giving errors, but none of them are introduced by this pull request. I'm not clear on how previous CI tests have passed without these errors.

@acaire
Copy link
Contributor

acaire commented Jan 29, 2016

@cdodd Cheers for the pull request - Due to a newer version of flake8/pep8 by the looks, i'll investigate.

@acaire
Copy link
Contributor

acaire commented Jan 29, 2016

please rebase

@cdodd
Copy link
Contributor Author

cdodd commented Jan 29, 2016

Done

@cdodd
Copy link
Contributor Author

cdodd commented Jan 29, 2016

I rebased before cotdsa@7a38d25, I've now rebased again.

@acaire
Copy link
Contributor

acaire commented Feb 8, 2016

@cdodd apologies for the delay, I've been discussing the rewrite with @peterkh - Happy with this for now, although I think it's more appropriate that key_profile becomes boto_profile or similar.

It might also be worthwhile setting the param default to None and always passing boto_profile via the cloudformation.connect_to_region calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants