fix: also export types for node next module resolution #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using node next / node16 module resolution (`exports` field), then Typescript will no longer check `types` field in package json but use `types` from the `exports` field that is currently being used. Signed-off-by: Ferdinand Thiessen <[email protected]>
|
Not sure why the tests are failing. I'll check it a bit later. |
|
@perry-mitchell Every run fails on a other test, it seems like the But I can not think of any way this is related to this PR. Edit: I can reproduce this locally even with current master and latest Node, so it seems the WebDAV server has problems with current Node? (as 20 works the problem happens starting with Node 22). |
perry-mitchell
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using node next / node16 module resolution (
exportsfield), then Typescript will no longer checktypesfield in package json but usetypesfrom theexportsfield that is currently being used.