pcp2elasticsearch: support dynamic mapping #2117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elasticsearch 7.X removed the concept of mapping types (initially this was
depreciated in Elasticsearch 6.X).
Change over to support dynamic mapping by making use of the updated
'POST {server}/{index}/_doc' index API with auto-generated ids by default.
Users can still use the the search type '-p pcp-metric' command line argument
on launch to make use of the original pcp-metric mapping name for environments
with Elasticsearch 5.X and 6.X, ('POST {server}/{index}/{search_type}' API).
Note: These older versions are considered EOL by Elastic.
This fix addresses github issue performancecopilot#1998.
|
Thanks! I haven't followed Elasticsearch recently but based on your explanation this certainly makes sense. However, looking at the CI runs were some of the related QA test cases skipped? Have you checked locally is there any QA impact with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch 7.X removed the concept of mapping types (initially this was depreciated in Elasticsearch 6.X).
Change over to support dynamic mapping by making use of the updated 'POST {server}/{index}/_doc' index API with auto-generated ids by default.
Users can still use the the search type '-p pcp-metric' command line argument on launch to make use of the original pcp-metric mapping name for environments with Elasticsearch 5.X and 6.X, ('POST {server}/{index}/{search_type}' API).
Note: These older versions are considered EOL by Elastic.
This fix addresses github issue #1998.