Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERA-1159 :: Handle account selection automatically in ARC-78 flow #101

Merged
merged 2 commits into from
Jan 10, 2025
Merged

PERA-1159 :: Handle account selection automatically in ARC-78 flow #101

merged 2 commits into from
Jan 10, 2025

Conversation

yasin-ce
Copy link
Collaborator

Pull Request Template

Description

  • If user has authority of the address we receive in the wallet we are redirecting to keyreg transaction page otherwise we are showing an error message.

Related Issues

Checklist

  • Have you tested your changes locally?
  • Have you reviewed the code for any potential issues?
  • Have you documented any necessary changes in the project's documentation?
  • Have you added any necessary tests for your changes?
  • Have you updated any relevant dependencies?

Additional Notes

  • Add any additional notes or comments that may be helpful for reviewers.

@yasin-ce yasin-ce added the enhancement New feature or request label Jan 10, 2025
@yasin-ce yasin-ce added this to the 5.16.0 milestone Jan 10, 2025
@yasin-ce yasin-ce self-assigned this Jan 10, 2025
@michaeltchuang michaeltchuang changed the title PERA-1159 :: Handle account selection automatically in immersive flow PERA-1159 :: Handle account selection automatically in ARC-78 flow Jan 10, 2025
michaeltchuang
michaeltchuang approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@michaeltchuang michaeltchuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was able to keyreg offline, nice work

@michaeltchuang michaeltchuang merged commit 8f3bfed into dev Jan 10, 2025
11 checks passed
@michaeltchuang michaeltchuang deleted the PERA-1159 branch January 10, 2025 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michaeltchuang michaeltchuang michaeltchuang approved these changes

@mitsinsar mitsinsar Awaiting requested review from mitsinsar mitsinsar is a code owner

Assignees

@yasin-ce yasin-ce

Labels
enhancement New feature or request
Projects
None yet
Milestone
5.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yasin-ce @michaeltchuang