Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend node version up #502

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Amend node version up #502

merged 3 commits into from
Oct 22, 2024

Conversation

ebma
Copy link
Member

@ebma ebma commented Oct 17, 2024 •
edited
Loading

Follow-up to #485, fixing a minor issue.

After merging #485 I tried to run the workflow but it failed because the file name was wrong.

  • Fix reference to file
  • Remove unused files

@ebma ebma requested a review from a team October 17, 2024 09:01
gianfra-t
gianfra-t approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@gianfra-t gianfra-t left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍. Will we never use the runtime version up script again?

@ebma
Copy link
Member Author

ebma commented Oct 17, 2024

I'm not sure honestly. Probably best to wait for feedback from @b-yap on this.

@b-yap b-yap merged commit c0ff2a6 into main Oct 22, 2024
2 checks passed
@b-yap b-yap deleted the amend-456-node-version-up branch October 22, 2024 09:10
@b-yap
Copy link
Contributor

b-yap commented Oct 22, 2024

Looks fine. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianfra-t gianfra-t gianfra-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebma @b-yap @gianfra-t