-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-21480 update pom.xml to point to CLDR maven #1
base: ICU-21480-brs69rc-integrateCLDR-39-alpha0
Are you sure you want to change the base?
ICU-21480 update pom.xml to point to CLDR maven #1
Conversation
srl295
commented
Feb 2, 2021
- updated README as well
- deleted install-cldr-jars.sh
@pedberg-icu following the instructions in icu/tools/cldr/cldr-to-icu/README.txt I get this error:
|
I got further with this change, but i haven't put it into the PR: diff --git a/tools/cldr/cldr-to-icu/build-icu-data.xml b/tools/cldr/cldr-to-icu/build-icu-data.xml
index ea2f6e3f87..f1b9af507b 100644
--- a/tools/cldr/cldr-to-icu/build-icu-data.xml
+++ b/tools/cldr/cldr-to-icu/build-icu-data.xml
@@ -197,7 +197,7 @@
mt, mua, my, mzn
// N
- naq, nb, nb_NO, nb_SJ, nd, ne, nl, nmg, nn, nnh, no, no_NO_NY, nus, nyn
+ naq, nb, nd, ne, nl, nmg, nn, nnh, no, no_NO_NY, nus, nyn
// O
om, or, os
@@ -290,7 +290,7 @@
// K-P
ka, kk, kl, km, kn, kok, ko, ku, ky, lb, lkt, ln, lo, lt, lv,
- mk, ml, mn, mo, mr, ms, mt, my, nb, nb_NO, ne, nl, nn, no, no_NO,
+ mk, ml, mn, mo, mr, ms, mt, my, nb, ne, nl, nn, no, no_NO,
om, or, pa_IN, pa, pa_Guru, pl, ps, pt,
// R-T |
@hagbard it seems icu4c/source/data/build.xml is completely obsolete, and I delete it here. It seems the "generate production data" part that was all that was left is not needed because cldr-to-icu already consumes production data from cldr-staging. |
No issues from me! (sorry for not being more attentive to this recently, I just started ramping up on a new project that's taking all my time). |
Thanks for this. I have the integration working with the current process in my main PR (most of the work not pushed yet). Let me fix some test failures on that, then I will take a closer look at this. |
1279a61
to
b0370b7
Compare
and fix a bug in Java UnicodeSet.retain(String) which added the string even if the set did not contain it before, and some drive-by API doc fixes/clarifications
A regex pattern containing nested look-behind blocks could trigger an assertion failure during pattern compilation. The problem was caused by an off-by-one error in the code that computes an upper bound on the match length, needed because look-behind expressions are constrained to not have unbounded match length. Nested look-behind blocks come into play because, when computing the maximum match length of an outer block, any inner look-behind blocks are skipped over - they do not directly contribute to the length matched by the outer block. The problem was in the code that skips over these nested look-behind blocks.
… CLDR units Identifier See unicode-org#1586
…ith GitHub Actions.
to the icu repository. Added Unicode copyright notice to those files that only have the IBM copyright notice. A complimentary PR will remove data from the icu-data repository. ICU-21487 Adds pure test data files which have no copyright notice to the exemption list.
test runs with ICU stub data only. ICU-21502 Review comments worked in.
- Supplied missing API comment to com.ibm.icu.nubmer.Precision#trailingZeroDisplay(TrailingZeroDisplay) - Generated API signature file for ICU4J 69.1 and added to the repository - Delete ICU4J 59 API signature file - Deleted unused icu4j/eclipse-build/build.properties. The folder eclipse-build was deleted, but someone worked on ICU version seemed to add it back again. Delete it again.
Also dropped ICU4J 64 test data.
evaluates to the empty string and the result files are missing the perf test name as a result. E.g. '_Mar_16_155820.html' instead of 'unisetperf_Mar_16_155820.html'. Not obvious why the regex was even created since it doesn't seem necessary because the name of the caller doesn't require additional parsing. The rpaticular code is from 2002, maybe changes in Perl account for the issue(?)
Do not free baseName if it is pointing to fullNameBuffer. Better Fix
- improve checks for CLDR resolutions - update batch fetch from 50 to 100 - do not show no-commit tickets under illegal-state - add navigation - use numeric IDs for status, resolution, types with constants (S_, R_, I_) fix bugs from CLDR-14224 - do not show not-in-query issues as open - cache single-issue queries - give information on each problem as to what it is - put 'review' in a separate section (not counted in Problems) - more detailed fix info under each issue - fix section headings, always show component, add nocopyright option - sort open issues by componnent - sort the 'review' list ICU-20444: - exclude (via git-cherry) any commits already cherry picked to the branch. - used a workaround to gitpython-developers/GitPython#846 that seemed to work well, - warn about issues with excluded commits CLDR-14524: - Exclude "Obsolete" from requiring commits
clang 11 throws an error when using undefined variables starting with TARGET_OS_, and TARGET_OS_SIMULATOR is missing in earlier versions of macOS, so the code would not compile without an additional guard. See also ICU-13440.
0ee846b
to
afbf646
Compare
- updated README as well - deleted install-cldr-jars.sh
afbf646
to
5ded363
Compare