-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python 3.7 syntax to 3.8 #956
Conversation
Filter all code over `pyupgrade --py38-plus`. Signed-off-by: Tomasz Kłoczko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Sorry that it took a while to respond)
Love it!
The CI/CD is failing so that is something to check out.
Only one other comment: what do you think of using f-strings everywhere? I know pyupgrade is intentionally timid when converting to f-strings, but I think it is more readable in our almost all of our cases.
# Conflicts: # tools/dumppdf.py
@kloczek Thanks for your contribution! |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Thank you |
Pull request
Filter all code over
pyupgrade --py38-plus
.How Has This Been Tested?
I;m using my typical packaging procedure:
python3 -sBm build -w --no-isolation
build
with--no-isolation
I'm using during all processes only locally installed modulesinstaller
modulecut off from access to the public network
(pytest is executed with-m "not network"
)Checklist