NeoForge support #356
Draft
NeoForge support #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows changes made to neoforge to be seen more clearly.
This configures the neoforge build, but does not address critical bugs that prevent the neoforge build from functioning.
…rt in fasback-forge' At-least I believe it does. Uploading was failing with a jgit error aboud failing to negotiate the algorithm. Uploading to gitea and github now work after this change, which indicates to me that this issue is resolved. However, org.apache.sshd goes missing in development environments, and the SshHacks fix does not work anymore because of the library change. I've made an issue in architectury-loom for this: architectury/architectury-loom#248 In addition, the error thrown due to org.apache.sshd going missing is now being logged, but will not prevent fastback from loading. Allowing the development environment to still be used without support for ssh.
…osaves) is not currently supported on Forge' Mixins are used in much the same way they are in the fabric version.
ModLoadingContext can be supplied to the Mod's constructor, so using it.
stewi1014
commented
Nov 26, 2024
| filesMatching("META-INF/neoforge.mods.toml") { | ||
| expand "version": project.version | ||
| } | ||
| } |
There was a problem hiding this comment.
processResources is duplicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a NeoForge build of fastback
It depends on #355
ssh does not function in the NeoForge development environment, but works in the shadow jar; architectury/architectury-loom#248. I figure that might take a while to get a resolution to, and I'd vouch for not waiting on it given the bug only happens in development.
#260 and #261 are addressed in this PR.
I haven't looked into #313 and #264, and I'll mark this as ready once I do.
I've organized commits in this PR so they're easy to follow and understand, but it's probably worth squash-merging this.