Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28 ranged int #38

Closed
wants to merge 14 commits into from
Closed

28 ranged int #38

wants to merge 14 commits into from

Conversation

IBims1NicerTobi
Copy link
Collaborator

No description provided.

@IBims1NicerTobi IBims1NicerTobi self-assigned this Dec 5, 2024
src/codegen_fallback.rs Outdated Show resolved Hide resolved
src/instantiation/execute.rs Outdated Show resolved Hide resolved
src/to_string.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe nothing was actually changed in this file, and it's just a cargo fmt run?

@IBims1NicerTobi
Copy link
Collaborator Author

@VonTum what exactly happens here now?

if let ConcreteTemplateArg::NotProvided = &template_args[*template_id] {
    template_args[*template_id] = ConcreteTemplateArg::Type(connected_typ.clone(), HowDoWeKnowTheTemplateArg::Inferred)
}

Does this just turn into

if let ConcreteType::Unknown(_) = &template_args[*template_id].kind {
    template_args[*template_id] = ConcreteTemplateArg {
        kind: connected_typ.clone(),
        source: HowDoWeKnowTheTemplateArg::Inferred,
    }
}

Or do I have to do something with the id from the ConcreteType::Unknown?

@VonTum
Copy link
Collaborator

VonTum commented Jan 7, 2025

So just for context, you're looking to eliminate the ConcreteTemplateArg struct right? I recall us talking about this during our last meeting.

Certainly it is not possible to simply replace the Unknown with a copy of the type, rather it would need to be unified, using the local typ_substitutor.unify(). Let's discuss this tomorrow.

@IBims1NicerTobi
Copy link
Collaborator Author

Since we didn't really talk about that this week can you maybe just answer the question here?

@IBims1NicerTobi
Copy link
Collaborator Author

I can provide more info if you need it

@IBims1NicerTobi
Copy link
Collaborator Author

@VonTum I have ported ConcreteGlobalReference so I think this can be closed right?

@VonTum VonTum mentioned this pull request Jan 14, 2025
@VonTum
Copy link
Collaborator

VonTum commented Jan 14, 2025

Discontinued in favor of #50

@VonTum VonTum closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants