[WIP] Replace HK2/Types/Parser/Scanner with Jandex and cache in the domain #7165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I-enabled library JARs - correctly copy BDA sets for each war in EAR - Make WAR's CDI beans available in EAR-libs - read web-fragment.xml from EAR-libs - processing ear-lib manifest - de-duplicate BDAs in CDI processing by using LinkedHashSet intead of ArrayList - made some structures final (cleanup) - fixed ear and concurrent classloader leaks, including refactored reflection caching
…s=true is specified
lprimak
changed the title
| void index(DeploymentContext deploymentContext) throws IOException; | ||
| void reindex(DeploymentContext deploymentContext) throws IOException; | ||
| boolean isJakartaEEApplication(DeploymentContext deploymentContext) throws IOException; | ||
| Index getRootIndex(DeploymentContext deploymentContext); |
There was a problem hiding this comment.
You might want to avoid spreading the JBoss classes like i.e. Index around in the Payara codebase.
There was a problem hiding this comment.
Index is kinda the whole point of this PR.
The issue is that current annotation scanning framework is not made for CDI, is slow, and can't be cached.
Jandex is a small, separate project, has no dependencies, and is tailor made for CDI.
While it did come from JBoss, it's no longer embedded in that ecosystem and can be used unencumbered.
Any effort to isolate Index class will result in an unnecessary wrapper that would not add any value.
Do you have a specific suggestion? Am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy performance improvements
Fixes #7079