chore(demo): fix for nested levels in package demo #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessiehuff
approved these changes
Mar 15, 2024
jenny-s51
reviewed
Mar 18, 2024
There was a problem hiding this comment.
Nesting depth looks good and works as expected 👍 Labels for nested groups could use some additional spacing since there are multiple nested groups in the same area... WDYT @jeff-phillips-18 ? If this is out of scope, would it be worth opening a follow-up issue?
jeff-phillips-18
force-pushed
the
nested-level-fix
branch
from
e5b2b0f to
8cd1ae6
Compare
|
@jenny-s51 Updated the padding. https://nested-levels.surge.sh/ |
jenny-s51
approved these changes
Mar 25, 2024
|
🎉 This PR is included in version 5.3.0-prerelease.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Topology Package demo nesting depth setting. The setting was not being used when creating nodes.
Type of change