-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipelines): Add pipeline groups layout #157
feat(pipelines): Add pipeline groups layout #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Group layouts look awesome @jeff-phillips-18 🎉
Wondering it if would make sense to update the default label positioning to "top" in order to align with the designs and visually distinguish where the groups begin... In the vertical example, the labels for Executions 1 and 2 are positioned over forks of edges so it's a bit tricky to figure out which series of nodes the execution label refers to. WDYT @jeff-phillips-18 ?
Question: You have a colour shift for the internal groups -- does this mean there are only allowed one layer of groups inside groups? If not, what does it look like if another group is inside the inner group? |
@andrewballantyne the group background alternates: |
b9fa2ed
to
0b23db1
Compare
0b23db1
to
f74883d
Compare
@jenny-s51 Moved them to the top for vertical layout (this is in the app code not the toolkit) |
Design wise this lgtm -- I didn't dive into the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ran it locally with out any issues. Code looks good.
🎉 This PR is included in version 5.3.0-prerelease.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What
Closes #155
Closes RHOAIENG-4186
Description
Adds a
DagreGroupsLayout
andPipelineDagreGroupsLayout
which treats each group as its own layout. Groups are connected to tasks or other groups.Type of change
Screen shots / Gifs for design review
Horizontal
Vertical
/cc @andrewballantyne
Surge
https://pipeline-groups.surge.sh/