Feat/use aave client lib in tests #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakulstra
commented
Apr 2, 2021
sakulstra
commented
Apr 6, 2021
|
Could you maybe move your changed script to a separate script file, and restore the original script to how it was? And take the token to test as a command line argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello this is a little draft using aave client lib inside one of the tests.
The test succeeded so I guess this is a good start 🎉
Creating this pr so i can ask questions in code.
In theory the client should be capable of dositing eth directly (in fact at the moment aave app doesn't offer a way to directly deposit weth at all), but for some reason this didn't work - didn't yet figure out why.