This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 177
bugfix for dict based identity #63
Open
pall-valmundsson
wants to merge
2
commits into
pallets-eco:master
Choose a base branch
from
pall-valmundsson:fix_dict_identity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
bugfix for dict based identity #63
pall-valmundsson
wants to merge
2
commits into
pallets-eco:master
from
pall-valmundsson:fix_dict_identity
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a dict object to represent an identity the default jwt_encode_callback handler fails as getattr does not work with dict objects. This change sets the default value of getattr to None so the dict get part of the statement is evaluated.
Please merge this 👍 |
👍 |
👍 (same as my pull request #79 - I did not notice this one). |
I have run into the same error when retrieving identity from RethinkDB, which return in dict. I would create my own PR if I did not find this PR. by the way, how about make it this way
feel more robust Wish it being merged soon. |
Hello, I just ran into the same issue, please merge :) Regards, Adam. |
@mattupstate this is a fairly urgent and easy bug to fix |
@mattupstate this issue still not fixed, please merge |
I don't intend to maintain the fork but in the meantime, I merged several nice PRs and fixes into https://github.com/webstack/flask-jwt/commits/fork |
This was referenced Aug 3, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a dict object to represent an identity the default jwt_encode_callback handler fails as getattr does not work with dict objects. This change sets the default value of getattr to None so the dict get part of the statement is evaluated.
The tests required a different implementation of the app fixture.