-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mail panel #99
base: main
Are you sure you want to change the base?
add mail panel #99
Conversation
Any chance that this will be merged and released soon? Or should i create a third party panel from it? |
I'm +1 for this. @mgood your thoughts? |
|
||
flask_debugtoolbar.panels.mail.MailDebugPanel | ||
|
||
Shows mails send with flask_mail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's some slightly improved docs...
Shows mails that have been sent with `Flask-Mail`_. Use MAIL_SUPPRESS_SEND=True so the mail is not sent.
.. _Flask-Mail: https://pythonhosted.org/Flask-Mail/
@jeffwidman up to you, but my thought in #50 was to move towards just having better docs for 3rd party panels. That way people can find and install extra panels that apply to them. I think that model also makes it easier for other people to distribute and update the extra panels on their own timeline without depending on new releases of this package. |
I know it's been a long time, but do you still have any interest in this? |
I am working on https://github.com/rimvislt/flask-mail2 which is a fork from the previous no longer supported flask-mail. I am wondering if this debug panel should be added to the flask-mail2 repo instead of having it here. Let me know what you think about it. |
It's up to you where/how you want to contribute it. If there are a critical mass of people who use Flask Debug Toolbar and also use a Flask-Mail compatible library as well, I suspect they'd find it useful. Personally I'm not in that group of people yet, and I don't know how big that group is, but I'm not opposed to having it here, since it seems small and well contained. |
The So closing this... If the Flask ecosystem coalesces around another mail extension in the future, then I'd be open to a Flask DBT panel getting added. |
Actually, NVM, I just heard from @davidism that archiving those may be a temp state of affairs... unclear, but for now I'm fine with leaving this open and floating... |
Hello,
i added a simple mail panel, to inspect mails send via flask_mail. This is perfekt to develop register/lost passwords and others features.
Works great with
in the dev config.