Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

[SELC-5223] feat: remove product pagoPa condition in createDelegation #522

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

giulia-tremolada
Copy link
Collaborator

@giulia-tremolada giulia-tremolada commented Jul 3, 2024

List of Changes

  • remove product pagoPa condition in createDelegation
  • remove and align unit tests

Motivation and Context

This change was required to move product pagoPa logic from BE to BFF.
With this modification createDelegation API on ms-core is semplied and reusable.

How Has This Been Tested?

It was tested locally by running both ms-core and bff-dashboard locally and calling createDelegation API. on bff-dashboard.
It was tested with both product prod-pagopa and prod-io.

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@giulia-tremolada giulia-tremolada marked this pull request as ready for review July 4, 2024 07:11
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner July 4, 2024 07:11
Copy link

sonarqubecloud bot commented Jul 4, 2024

@giulia-tremolada giulia-tremolada merged commit 72a1ab7 into main Jul 4, 2024
11 checks passed
@giulia-tremolada giulia-tremolada deleted the feature/SELC-5223 branch July 4, 2024 08:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants