Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

[SELC-4910] feat: remove aggregation to retrieve taxCode field #499

Merged
merged 9 commits into from
May 24, 2024

Conversation

giulia-tremolada
Copy link
Collaborator

@giulia-tremolada giulia-tremolada commented May 24, 2024

List of Changes

  • remove aggregation to retrieve taxCode
  • add filter taxCode in collection Delegation
  • add delegation response mapper to return the appropriate taxCode
  • remove mode filter
  • align unit tests
  • align open api

Motivation and Context

This change is related to the addition of fields toTaxCode and fromTaxCode in collection Delegation, in this way it's possible to retrieve taxCode direclty from Delegation Collection.

How Has This Been Tested?

It was tested by running locally both getDelegations and getDelegationsV2 APIs

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

manuraf
manuraf previously approved these changes May 24, 2024
@giulia-tremolada giulia-tremolada marked this pull request as ready for review May 24, 2024 13:21
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner May 24, 2024 13:21
Copy link

@giulia-tremolada giulia-tremolada merged commit dde16c8 into main May 24, 2024
10 checks passed
@giulia-tremolada giulia-tremolada deleted the feature/SELC-4910 branch May 24, 2024 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants