This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
[SELC-4041] refactor: send contracts using ContractNotificationService #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
manuraf
added a commit
that referenced
this pull request
Feb 15, 2024
* refactor: remove unused token connector method (#386) * [SELC-4041] refactor: send contracts using ContractNotificationService (#390) * contract service notification * object mapper * fix conditional property * remove unused code * [SELC-4086] feat: added API to retrieve all User from userIds (#401) * Added API to retrieve all User from userIds * Fixed unit test about onboarded-users * Removed redundant object OnboardedUserResponse --------- Co-authored-by: [email protected] <Aiap1955?^@#> * [SELC-4228] fix: add institutionType in createInstitution from IPA (#403) --------- Co-authored-by: andrea-putzu <[email protected]> Co-authored-by: pierpaolodidato89 <[email protected]> Co-authored-by: [email protected] <Aiap1955?^@#> Co-authored-by: Giulia Tremolada <[email protected]>
manuraf
added a commit
that referenced
this pull request
Feb 20, 2024
* refactor: remove unused token connector method (#386) * [SELC-4041] refactor: send contracts using ContractNotificationService (#390) * contract service notification * object mapper * fix conditional property * remove unused code * [SELC-4086] feat: added API to retrieve all User from userIds (#401) * Added API to retrieve all User from userIds * Fixed unit test about onboarded-users * Removed redundant object OnboardedUserResponse --------- Co-authored-by: [email protected] <Aiap1955?^@#> * [SELC-4228] fix: add institutionType in createInstitution from IPA (#403) * Release uat (#404) * refactor: remove unused token connector method (#386) * [SELC-4041] refactor: send contracts using ContractNotificationService (#390) * contract service notification * object mapper * fix conditional property * remove unused code * [SELC-4086] feat: added API to retrieve all User from userIds (#401) * Added API to retrieve all User from userIds * Fixed unit test about onboarded-users * Removed redundant object OnboardedUserResponse --------- Co-authored-by: [email protected] <Aiap1955?^@#> * [SELC-4228] fix: add institutionType in createInstitution from IPA (#403) --------- Co-authored-by: andrea-putzu <[email protected]> Co-authored-by: pierpaolodidato89 <[email protected]> Co-authored-by: [email protected] <Aiap1955?^@#> Co-authored-by: Giulia Tremolada <[email protected]> * feat: added new boolean delegation to institution and added status, createdAt and updatedAt to Delegation (#405) * fix: avoid save mail on pdv id empty (#406) * [SELC-4191] fix: modify email subjects (#407) --------- Co-authored-by: andrea-putzu <[email protected]> Co-authored-by: pierpaolodidato89 <[email protected]> Co-authored-by: [email protected] <Aiap1955?^@#> Co-authored-by: Giulia Tremolada <[email protected]> Co-authored-by: gianmarcoplutino <[email protected]>
manuraf
added a commit
that referenced
this pull request
Mar 1, 2024
* [EC-150] Add empty GitHub workflows to allow testing with private branches (#391) * [EC-129] Add repository environments (#393) * [EC-150] Add PR GitHub pipeline (#395) * [EC-150] Add pipelines for release (#397) * [EC-150] Misc minor changes for GitHub workflows (#398) * fix: Bug on deploy to env * feature: added api to retrieve delegations with pagination * fix: Add Page size * fix: Add Delegation filter data * [EC-129] Move GitHub repository settings to common module (#402) * fix: Add Delegation filter data * 143 * fix page size * Release PROD (#410) * refactor: remove unused token connector method (#386) * [SELC-4041] refactor: send contracts using ContractNotificationService (#390) * contract service notification * object mapper * fix conditional property * remove unused code * [SELC-4086] feat: added API to retrieve all User from userIds (#401) * Added API to retrieve all User from userIds * Fixed unit test about onboarded-users * Removed redundant object OnboardedUserResponse --------- Co-authored-by: [email protected] <Aiap1955?^@#> * [SELC-4228] fix: add institutionType in createInstitution from IPA (#403) * Release uat (#404) * refactor: remove unused token connector method (#386) * [SELC-4041] refactor: send contracts using ContractNotificationService (#390) * contract service notification * object mapper * fix conditional property * remove unused code * [SELC-4086] feat: added API to retrieve all User from userIds (#401) * Added API to retrieve all User from userIds * Fixed unit test about onboarded-users * Removed redundant object OnboardedUserResponse --------- Co-authored-by: [email protected] <Aiap1955?^@#> * [SELC-4228] fix: add institutionType in createInstitution from IPA (#403) --------- Co-authored-by: andrea-putzu <[email protected]> Co-authored-by: pierpaolodidato89 <[email protected]> Co-authored-by: [email protected] <Aiap1955?^@#> Co-authored-by: Giulia Tremolada <[email protected]> * feat: added new boolean delegation to institution and added status, createdAt and updatedAt to Delegation (#405) * fix: avoid save mail on pdv id empty (#406) * [SELC-4191] fix: modify email subjects (#407) --------- Co-authored-by: andrea-putzu <[email protected]> Co-authored-by: pierpaolodidato89 <[email protected]> Co-authored-by: [email protected] <Aiap1955?^@#> Co-authored-by: Giulia Tremolada <[email protected]> Co-authored-by: gianmarcoplutino <[email protected]> * feature: Added activatedAt field to the updateCreatedAt API. * fix: Delegation default page size * fix: Delegation remove filter api * fix: Delegation remove filter api * fix: Add async to notification api * [SELC-4419] fix : send contract by institutionId and tokenId (#417) * send contract by institutionId and tokenId * some comments * [SELC-4419] fix : send contract by institutionId and tokenId (#418) * send contract by institutionId and tokenId * some comments * filter for ACTIVE and DELETED --------- Co-authored-by: Andrea Grillo <[email protected]> Co-authored-by: gianmarcoplutino <[email protected]> Co-authored-by: empassaro <[email protected]> Co-authored-by: Manuel Rafeli <[email protected]> Co-authored-by: pierpaolodidato89 <[email protected]> Co-authored-by: [email protected] <Aiap1955?^@#> Co-authored-by: Giulia Tremolada <[email protected]> Co-authored-by: empassaro <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
Refactor of business logic for sending ScContract notification using an appropriate service that can ignore send action. It is useful for PNPG use case where sending is disabled.
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: