[PRDP-220] Fix queue-cosmos desync #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Comment this PR with update_code to update |
|
Kudos, SonarCloud Quality Gate passed! |
svariant
added a commit
that referenced
this pull request
Nov 21, 2023
* [PRDP-220] Added save receipt method to cosmos client * [PRDP-220] Added new reason error code for cosmos * [PRDP-220] Implemented cosmos client and refactored code * [PRDP-220] Changed BizEventToReceipt function logic to fix queue-cosmos desynch * [PRDP-220] Updated unit tests * [PRDP-220] Fix RecoverFailedReceipt function save failed queue status * [PRDP-220] Fixed Cosmos Client insert by generating custom id for receipt * [PRDP-220] Update unit tests * [PRDP-220] Added charset utf-8 to bizEvent stringify
pasqualespica
added a commit
that referenced
this pull request
Nov 23, 2023
* [PRDP-224] Changed cart item subject retrieve logic * [PRDP-224] Updated unit tests * [PRDP-220] Fix queue-cosmos desync (#99) * [PRDP-220] Added save receipt method to cosmos client * [PRDP-220] Added new reason error code for cosmos * [PRDP-220] Implemented cosmos client and refactored code * [PRDP-220] Changed BizEventToReceipt function logic to fix queue-cosmos desynch * [PRDP-220] Updated unit tests * [PRDP-220] Fix RecoverFailedReceipt function save failed queue status * [PRDP-220] Fixed Cosmos Client insert by generating custom id for receipt * [PRDP-220] Update unit tests * [PRDP-220] Added charset utf-8 to bizEvent stringify * Bump to version 1.7.0 * Bump to version 1.7.0-1 [skip ci] * [PRDP-224] Updated unit tests * [PRDP-224] Fixed condition transfer list exist * [PRDP-224] Updated unit tests * [PRDP-224] Implemented regex for remittance information retrieving * [PRDP-224] Cleaned code * [PRDP-224] Changed regex --------- Co-authored-by: pagopa-github-bot <[email protected]> Co-authored-by: pasqualespica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Motivation and Context
Issue PRDP-220
The event was sent to the queue before the receipt was saved on cosmos.
This was causing errors in the ReceiptGenerator that was triggered by the queue but couldn't find the relative receipt in the cosmos.
How Has This Been Tested?
Unit tests have been updated and run
Types of changes
Checklist:
A new type of error code has been defined (904) in case of generic errors in the cosmos client, the documentation