Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRDP-224] Changed Remittance Information retrieve logic #100

Merged
merged 12 commits into from
Nov 23, 2023

Conversation

svariant
Copy link
Collaborator

List of Changes

  • Changed Remittance Information retrieve logic following the given diagram
  • Updated Unit tests

Motivation and Context

Issue PRDP-224

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@svariant svariant added the patch label Nov 21, 2023
@svariant svariant marked this pull request as draft November 21, 2023 14:50
svariant and others added 6 commits November 21, 2023 16:26
* [PRDP-220] Added save receipt method to cosmos client

* [PRDP-220] Added new reason error code for cosmos

* [PRDP-220] Implemented cosmos client and refactored code

* [PRDP-220] Changed BizEventToReceipt function logic to fix queue-cosmos desynch

* [PRDP-220] Updated unit tests

* [PRDP-220] Fix RecoverFailedReceipt function save failed queue status

* [PRDP-220] Fixed Cosmos Client insert by generating custom id for receipt

* [PRDP-220] Update unit tests

* [PRDP-220] Added charset utf-8 to bizEvent stringify
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@svariant svariant marked this pull request as ready for review November 21, 2023 15:27
remittanceInformation = transfer.getRemittanceInformation();
}
}
if (remittanceInformation != null && remittanceInformation.contains(REMITTANCE_INFORMATION_SUBSTRING)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try rto use regex

@pasqualespica pasqualespica self-requested a review November 23, 2023 16:31
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

Copy link

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@pasqualespica pasqualespica merged commit 630751b into main Nov 23, 2023
5 of 8 checks passed
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.5% 80.5% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants