Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VAS-829] feat: add get folder status api #1

Merged
merged 16 commits into from
Apr 22, 2024

Conversation

alessio-cialini
Copy link
Collaborator

@alessio-cialini alessio-cialini commented Apr 16, 2024

List of Changes

  • Updated repository skeleton
  • Updated opex config
  • Updated identity config
  • Updated infra config
  • Introduced openApi file generation
  • Bump up of dependency versions
  • Introduced API to obtain a folder status from the MongoDB instance
  • Introduced unit testing

Motivation and Context

https://pagopa.atlassian.net/browse/VAS-829

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

helm/values-dev.yaml Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
*
* @param joinPoint not used
* @param result the response to validate
*/
// TODO: set your package
@AfterReturning(pointcut = "execution(* it.gov.pagopa.microservice.controller.*.*(..))", returning = "result")
@AfterReturning(pointcut = "execution(* it.gov.pagopa.payment.notices.service.controller.*.*(..))", returning = "result")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm considering if deleting this class form the template... 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be useful for some services. to determine if it will have some use in this one.

Co-authored-by: Jacopo Carlini <[email protected]>
alessio-cialini and others added 2 commits April 18, 2024 16:00
Co-authored-by: Jacopo Carlini <[email protected]>
Co-authored-by: Jacopo Carlini <[email protected]>
Copy link

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@jacopocarlini jacopocarlini merged commit 927c801 into main Apr 22, 2024
8 of 10 checks passed
@jacopocarlini jacopocarlini deleted the VAS-829-feat-add-get-folder-status-api branch May 13, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants