Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOD-682 request dates fix #22

Merged
merged 1 commit into from
Feb 2, 2024
Merged

NOD-682 request dates fix #22

merged 1 commit into from
Feb 2, 2024

Conversation

andrea-barchi
Copy link
Contributor

List of Changes

Request dates and fileType are no longer required. They will be set by default if left blank.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@andrea-barchi andrea-barchi requested a review from aomegax February 2, 2024 16:51
@andrea-barchi andrea-barchi requested a review from a team as a code owner February 2, 2024 16:51
@github-actions github-actions bot added the patch label Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

github-actions bot commented Feb 2, 2024

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link

github-actions bot commented Feb 2, 2024

This pull request does not contain a valid label. Please add one of the following labels: [breaking-change, new-release, ignore-for-release]

Copy link

github-actions bot commented Feb 2, 2024

Comment this PR with update_code to format the code. Consider to use pre-commit to format the code.

Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@aomegax aomegax merged commit 0013969 into main Feb 2, 2024
6 of 9 checks passed
@aomegax aomegax deleted the dates-fix branch February 2, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants